Re: Integer checks

On Sep 17, 1:34 am, Obnoxio The Clown <obno...@serendipita.com> wrote: > Jonathan Leffler wrote: > > On Sep 16, 2:22 pm, Obnoxio The Clown <obno...@serendipita.com> wrote: > > >> monkeys paw wrote: > > >>> This code snippet works perfectly, no compile probs even! > > >> Am I allowed to preen? Just a little? :o) > > > Just a little.  But only a little. > > > You forgot to check that the value was not negative, so -9999 passes > > your test for hours (< 23) -- you did check for non-negative minutes, > > but if I chose -100, that would have a remainder of zero, so the > > minutes would be valid and the hours would be OK too. > > > Just a tiny bit of help from one nit-picker to another. > > Ahem: > >     IF lv_time_in < 0 >     THEN >         ERROR "Negative time not allowed" >         RETURN FALSE >     END IF I need to get some sleep... You're right - I'm wrong. Ignore me and I'll ... go and get some sleep.